Fix inconsistent path parameter handling in Router #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overage The Router's `Handle` and `HandleRoute` methods handled path parameters inconsistently. This commit unifies the path parameter handling by ensuring `Handle` uses the same regex-based transformation as `HandleRoute`. Additionally, the test coverage dropped because the `ServeHTTP` method's handler invocation was not covered. This commit adds a test case that verifies the correct execution of handlers within `ServeHTTP`, ensuring complete test coverage and addressing the coverage gap. Changes include: - Modified `Handle` method to use the regex transformation for path parameters. - Added test case `TestRouter_Handle_ServeHTTP` to cover handler execution within `ServeHTTP`. This fix closes the issue where path parameters were not recognized when routes were registered using `Handle`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Router's
HandleandHandleRoutemethods handled path parameters inconsistently. This commit unifies the path parameter handling by ensuringHandleuses the same regex-based transformation asHandleRoute.Additionally, the test coverage dropped because the
ServeHTTPmethod's handler invocation was not covered. This commit adds a test case that verifies the correct execution of handlers withinServeHTTP, ensuring complete test coverage and addressing the coverage gap.Changes include:
Handlemethod to use the regex transformation for path parameters.TestRouter_Handle_ServeHTTPto cover handler execution withinServeHTTP.This fix closes the issue where path parameters were not recognized when routes were registered using
Handle.Closes #5